question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove code block splitting

See original GitHub issue

draft-js-code strength is handling what happens inside a code block. I think the module should focus more on that strength.

There’s a lot of other modules (like the markdown or WYSIWYG plugins) that add the UX for getting into and out of code blocks. draft-js-code is awesome alongside those modules. At the moment it’s in a weird spot where it doesn’t help users get into code blocks but it helps them split and exit code blocks, which doesn’t make much sense to me.

Rather than try to be a full-on solution for everything code, I want draft-js-code to be the go-to module for everything that happens inside of a code block.

In the next major version upgrade (1.0) I want to remove the code block splitting functionality. It’s only like 4 lines of code, so the “depreciation notice” would be a note in the changelog to add those 4 lines of code to your own app manually.

If nobody objects to this plan I’ll go ahead and make it happen, and then focus on inside-code-block improvements like #12 and #7!

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
williambomancommented, Sep 26, 2017

I’m 👍 on this. I currently override the return handler to avoid this from happening.

0reactions
mxstbrcommented, Oct 23, 2017

Released as v0.3.0 instead! (since that’s a major version pre-1.0 anyway)

Read more comments on GitHub >

github_iconTop Results From Across the Web

CodeBlocks Split Windows (cannot close)
Re: CodeBlocks Split Windows (cannot close)​​ I fear it is related to the saveing (or better restoring of the pany layout) introduced in...
Read more >
Separating consecutive code blocks - Meta Stack Exchange
Save this question. Show activity on this post. Currently, trying to put two code blocks one after the other results in one big...
Read more >
How can I ignore leading and trailing linebreaks within an html ...
Simply add the class indent-X where X is the amount of whitespace you want to remove to the pre . JSFiddle. Show code...
Read more >
Remove [code] [/code] from Email notification - ServiceNow
Solved: I am trying to remove the assignee name from the email notification and I have created an email script as below. When...
Read more >
Add and remove #region blocks - JetBrains Rider
To select a logical code block, press Alt+Shift+= one or more times; to select the current declaration, press Ctrl+Shift+[ .
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found