Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Errors running tests since upgrading to v5 of `ember-qunit`

See original GitHub issue

Migrating to v5 of ember-qunit causes issues with ember-cli-page-object. I suspect it is to do with the following breaking change

Actual error:

  Error: Could not find module `ember-test-helpers/wait` imported from `ember-cli-page-object/test-support/-private/execution_context/integration`

Issue Analytics

State:
Created 3 years ago
Reactions:2
Comments:7 (4 by maintainers)

Top GitHub Comments

3reactions

ro0grcommented, Jan 6, 2021

I’ve just published v2.0.0-beta.1. A noticeable change is that we’ve stopped importing adapters(previously known as private ExecutionContexts) eagerly, and now we require to import and set adapters manually in user land, see https://github.com/san650/ember-cli-page-object/pull/511 for some more details. I believe this change should avoid the issue with the ember-native-dom-helpers, which you’ve mentioned @cah-briangantzler.

If there are any sub tasks

I’d really like us to add ember-qunit@5 to our test matrix. There was some initial effort already https://github.com/san650/ember-cli-page-object/pull/516, but seems we still need to move it to the finish line, and target it to the v2-beta branch. It’d be great, if someone could help with this and make sure ember-qunit@5 is really supported!

2reactions

ro0grcommented, Jan 24, 2021

ember-qunit@5 support has been released as 1.17.5. Thanks everyone for making it happen! 🚀