Stack overflow when type checking very large objects

I have been using sanctuary-def for utility modules in a meteor app recently which has been mostly a joy. It is frequently necessary in meteor to read from a singleton app instance

// you may have seen...
import { Meteor } from 'meteor/meteor'

I was requiring this object as an argument to some checked functions, at first representing it in the signature as a $.RecordType that had some default properties, but sanctuary threw stack overflow errors when it came time to actually check this object to the tune of

W20161007-12:22:14.473(-4)? (STDERR) RangeError: Maximum call stack size exceeded
W20161007-12:22:14.473(-4)? (STDERR)     at validate (/project-path/node_modules/sanctuary-def/index.js:332:18)
W20161007-12:22:14.475(-4)? (STDERR)     at Object._test (/project-path/node_modules/sanctuary-def/index.js:276:14)
W20161007-12:22:14.475(-4)? (STDERR)     at /project-path/node_modules/sanctuary-def/index.js:856:53
W20161007-12:22:14.475(-4)? (STDERR)     at chain (/project-path/node_modules/sanctuary-def/index.js:82:26)
W20161007-12:22:14.476(-4)? (STDERR)     at /project-path/node_modules/sanctuary-def/index.js:854:14
W20161007-12:22:14.476(-4)? (STDERR)     at map (/project-path/node_modules/sanctuary-def/index.js:120:62)
W20161007-12:22:14.478(-4)? (STDERR)     at recur (/project-path/node_modules/sanctuary-def/index.js:843:19)
W20161007-12:22:14.478(-4)? (STDERR)     at determineActualTypesStrict (/project-path/node_modules/sanctuary-def/index.js:892:31)
W20161007-12:22:14.478(-4)? (STDERR)     at recur (/project-path/node_modules/sanctuary-def/index.js:1044:32)
W20161007-12:22:14.479(-4)? (STDERR)     at $.test (/project-path/node_modules/sanctuary-def/index.js:1079:12)
W20161007-12:22:14.479(-4)? (STDERR)     at /project-path/node_modules/sanctuary-def/index.js:1086:16
=> Exited with code: 1

So i changed the signature to expect $.Object, which yielded the same result.

One option is to just avoid this mess by having the calling code pick whatever it needs off of the large object before calling my utilities, but that kind of makes me sad.

[davidchambers]

Thanks for the bug report, @Koleok. Could you see whether you can reproduce this against master? @Avaq and I spent some time debugging a similar issue a few weeks ago only to realize that it’s no longer a problem on master.

One option is to just avoid this mess by having the calling code pick whatever it needs off of the large object before calling my utilities, but that kind of makes me sad.

That would sadden me too. We can certainly do better. 😃

I’m pleased to hear you’re finding sanctuary-def useful (and fun to use).

[Koleok]

Update: For now i had to just fork sanctuary-def and do an npm version minor to get it away from the 0.6.x specified in the sanctuary deps. I’ll look for those new versions!