Colon in uri generate response 404

Sanic can’t find the route if there’s a colon in the uri.

Code snippet

from sanic import Sanic, Request, HTTPResponse

app = Sanic('zzz')


@app.get(f'/abc/x:y')
async def main(_: Request):
    return HTTPResponse()


if __name__ == '__main__':
    app.run()

Expected behavior GET http://127.0.0.1:8000/abc/x:y 200 0

Actual behavior GET http://127.0.0.1:8000/abc/x:y 404 733

Environment

[2022-09-26 20:50:40 +0600] [13060] [INFO] Sanic v22.6.2
[2022-09-26 20:50:40 +0600] [13060] [INFO] Goin' Fast @ http://127.0.0.1:8000
[2022-09-26 20:50:40 +0600] [13060] [INFO] mode: production, single worker
[2022-09-26 20:50:40 +0600] [13060] [INFO] server: sanic, HTTP/1.1
[2022-09-26 20:50:40 +0600] [13060] [INFO] python: 3.10.5
[2022-09-26 20:50:40 +0600] [13060] [INFO] platform: Windows-10-10.0.19044-SP0
[2022-09-26 20:50:40 +0600] [13060] [INFO] packages: sanic-routing==22.3.0
[2022-09-26 20:50:40 +0600] [13060] [INFO] Starting worker [13060]

Additional context https://github.com/tiangolo/fastapi/issues/4892 https://github.com/encode/starlette/pull/1657

[ahopkins]

I am going to put this aside for now unless someone can make a compelling argument for why we need to handle this. It is the first time I have heard this come up and I am hesitant to add in support for this edge case when a viable alternative exists.

For anyone that needs:

from urllib.parse import quote

from sanic import Request, Sanic, json
from sanic.router import Router


class MyRouter(Router):
    def get(self, path, *args, **kwargs):
        return super().get(quote(path), *args, **kwargs)


app = Sanic("TestApp", router=MyRouter())


@app.route("/x:y")
async def handler(request: Request):
    return json({"foo": "bar"})

Or, perhaps a try/except is warranted:

    def get(self, path, *args, **kwargs):
        try:
            return super().get(path, *args, **kwargs)
        except NotFound:
            return super().get(quote(path), *args, **kwargs)

[Tronic]

Closing as WONTFIX, given that it against specs and as @ahopkins noted a rare corner case with viable workarounds for those who need it anyway.