One-to-one navigation properties with value null

Hello cloud-sdk-js,

I have a question concerning one-to-one navigation properties. Depending on the data they can be null although this is not specified in their type definition.

Example (@sap-cloud-sdk/core 1.39.0, @sap/cloud-sdk-op-vdm-business-partner-service 1.24.0):

const destination = getDestinationFromSomewhere();
const result = await BusinessPartner
	.requestBuilder()
	.getAll()
	.execute(destination);

If customer/supplier is not maintained the corresponding one-to-one navigation properties toCustomer and toSupplier are null which does not match their type definition:

/**
* One-to-one navigation property to the [[Customer]] entity.
*/
toCustomer: Customer;
/**
* One-to-one navigation property to the [[Supplier]] entity.
*/
toSupplier: Supplier;

This may cause problems when using the result in the BusinessPartner.builder().fromJson method because it would only accept Customer/Supplier or undefined.

Could you please have a look at this?

Thanks in advance.

[ja-ne]

Hi @jjtang1985, thanks for notifying about the fix. I’ve successfully tested with the canary version. Best regards, ja-ne

[jjtang1985]

Hi @ja-ne , the PR #1141 has been merged and you’ll find it in the next stable release. Please note, the fix contains two parts:

1. The @sap-cloud-sdk/core, which contains the fix of fromJson for the runtime error. This might be released next week.
2. The @sap/cloud-sdk-vdm-*, which contains the type-safe clients (type error at compile time). This might take a while for a new release.

For the time being, you can already test the canary version of @sap-cloud-sdk/core, which contains the fix. Please let know if it helps if possible.

Best, Junjie