question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Inconsistency between popover-list & menu

See original GitHub issue

Bug reported by Dost Arora:

  • A11Y: In Menu, the Accessibility dotted line appears when hovering over the element. In popover-list it appears after pressing tab. Is there any way to enable/disable this for Menu OR Popover ?
  • CSS: In popover, the corner of first & last element bleeds out from the edges. This does not happen in Menu. .fd-menu__list - has additional box-shadow -box-shadow: var(–sapContent_Shadow1, 0 0 0 .0625rem rgba(0, 0, 0, .42), 0 .125rem .5rem 0 rgba(0, 0, 0, .3)) apart from the popover shadow which makes the menu border looks darker. .fd-menu__link - has unbalanced left & right padding - padding: .75rem 1rem .75rem .75rem. Items are not centered. .fd-menu__title - has font-size var(–sapFontSize, .875rem), whereas .fd-list__title has font-size var(–sapFontLargeSize, 1rem)

Demo: https://stackblitz.com/edit/tpp-issue-2-list-menu-da25?file=src/app/menu-example.component.html

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:10 (7 by maintainers)

github_iconTop GitHub Comments

2reactions
platon-rovcommented, Feb 28, 2022

After the latest improvements only the first item of menu gets the focus styles. Then, when hovering over the items, they are getting hover styles, not focus. Focus styles applies to the items respectively when navigating over the menu items with keyboard. I think it makes sense.

https://user-images.githubusercontent.com/20265336/155976324-da04a3bc-a497-42c7-921a-4964e7e5b26c.mov

1reaction
mikerodonnell89commented, Mar 3, 2022

@dostarora97 the fix on your branch related to tpp-issue-3-menu-corners-da25 does solve the issue of rounded corners if the last-child is a div of 0 height but I don’t see when someone would build a menu like that - if the last-child is not a menu-item and it actually has some height, you get this (i’ve set the div height to 32px and background to red): Screen Shot 2022-03-03 at 9 08 58 AM

However with the issue tpp-recipe-1-dynamically-nested-menu-da25 I do think we will need to rework our approach to dynamically generated menus so I will look in to that and get back to you on this issue here

Read more comments on GitHub >

github_iconTop Results From Across the Web

Inconsistency between popover-list & menu · Issue #3168
Is there any way to enable/disable this for Menu OR Popover ? CSS: In popover, the corner of first & last element bleeds...
Read more >
How to bind bootstrap popover on dynamic elements
Update. If your popover is going to have a selector that is consistent then you can make use of selector property of popover...
Read more >
JavaScript
This means that switching from an open dropdown menu to a different dropdown menu requires an extra tap on mobile. Note: The data-toggle="dropdown"...
Read more >
Release Notes 2022
AWS Cloud Connectivity Checker Improvements; Weather Map: logo treatment for cloud regions is inconsistent between providers. Bug Fixes: Weathermap Error when ...
Read more >
Keep It 1.1 Release Notes Archive
Keep It will now switch to All Items when creating an item from ... When enabled, the import view will now be shown...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found