Styling Cleanup
See original GitHub issueIt looks like the technical debt with hardcoded styling in ngx has augmented. We need to address this asap. There are few options:
- the hardcoded styles in ngx has been already address in fundamental-styles repo
- the hardcoded styles in ngx is not reflected in fundamental-styles repo In case of the first option then the developer needs to remove the hardcoded styling; use the latest from styles; test and open a PR In case of the second, then the developer needs to bring it there, open a PR, test it, merge it, then do the steps above.
Denoland team:
-
libs/core/src/lib/busy-indicator/busy-indicator.component.scss
-
libs/core/src/lib/datetime-picker/datetime-picker.component.scss
-
libs/core/src/lib/dynamic-page/dynamic-page.component.scss
-
libs/core/src/lib/notification/notification/notification.component.scss
-
libs/core/src/lib/tabs/tab-list.component.scss
Ariba and Valor team:
-
libs/core/src/lib/avatar-group/avatar-group.component.scss
-
libs/core/src/lib/card/card.component.scss
-
libs/core/src/lib/facets/facet-group.component.scss
-
libs/core/src/lib/file-uploader/file-uploader.component.scss
-
libs/core/src/lib/fixed-card-layout/fixed-card-layout.component.scss
-
libs/core/src/lib/grid-list/components/grid-list-filter-bar/grid-list-filter-bar.component.scss
-
libs/core/src/lib/nested-list/nested-list-popover/nested-list-popover.component.scss
-
libs/core/src/lib/status-indicator/status-indicator.component.scss
-
libs/core/src/lib/toolbar/toolbar.component.scss
https://github.com/SAP/fundamental-ngx/pull/6396 -
libs/platform/src/lib/components/approval-flow/approval-flow.component.scss
-
libs/platform/src/lib/components/feed-input/feed-input.component.scss
- https://github.com/SAP/fundamental-ngx/issues/5343 -
libs/platform/src/lib/components/form/multi-input/multi-input.component.scss
-
libs/platform/src/lib/components/form/step-input/step-input.scss
do not usepx
values -
libs/platform/src/lib/components/list/standard-list-item/standard-list-item.component.scss
-
libs/platform/src/lib/components/table/table.component.scss
https://github.com/SAP/fundamental-ngx/pull/7062 -
libs/platform/src/lib/components/menu/menu-item.component.scss
Issue Analytics
- State:
- Created 2 years ago
- Comments:8 (5 by maintainers)
Top Results From Across the Web
Code style options and code cleanup - Visual Studio (Windows)
Learn how to configure Visual Studio to apply code style preferences using the Code Cleanup (Visual Studio 2019) and Format Document (Visual ...
Read more >Code style and cleanup | JetBrains Rider Documentation
Code style and cleanup · Using code inspections, JetBrains Rider detects and highlights symbol names inconsistent with your naming standards, ...
Read more >900+ Best Clean Up ideas in 2022 - Pinterest
Dec 20, 2022 - Explore cat's board "Clean Up" on Pinterest. ... Oh, Snap! More Than 100 Street-Styled Ways to Outfit Summer. cat...
Read more >How To Clean Up Text Styles - Web Guide
Are you having any issues with the way text is styled on your web site? Maybe the font size is too big or...
Read more >Styling Clean Up with Bash - RyanCheley.com
Styling Clean Up with Bash · ls -R templates | grep html | wc -l. There are 3 parts to this: ls -R...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Status Indicator, Multi Input, feed input - @Lokanathan-k Cards, Fixed card layout, standard list, grid list,nested list popover - @DeepakSap14 File Uploader, toolbar, step input,menu item - @manu-kr Table - @platon-rov Avatar Group, Facets- @kavya-b
@aberikashvili , please can you take over platform table and approval flow from Platon?