Enabled "manifestFirst" doesn't load resources defined in sap.ui5

OpenUI5 version: All

URL (minimal example if possible): https://embed.plnkr.co/4mURwe/ (Update 2017.04.22: Added mandatory attributes in the app descriptor)

Steps to reproduce the problem:

1. Define any CSS or JS resources in the sap.ui5 namespace of app descriptor
2. Enable manifestFirst either in the bootstrap configuration or in the component factory
3. If available, remove manifest: "json" from the component metadata in order to avoid loading the file twice.

What is the expected result? CSS and JS files are loaded and applied.

What happens instead? Requests for those files aren’t even sent.

Any other information? (attach screenshot if possible) I couldn’t find any mention about this behavior in the documentation. The CSS and JS resources gets loaded when manifest: "json" is defined in the component metadata. But this will send another request to manifest.json even if the descriptor was loaded already through manifestFirst.

[matz3]

@boghyon that’s right. We’ve optimized the manifest loading internally to share it with the ComponentMetadata class. Sorry for not updating this issue. This was done with https://github.com/SAP/openui5/commit/0e271c9db0fbbd8a04b4c5a5a0e6abad8ed11808.

If a URL is given instead (manifest: “myPath.json”), the manifest file is loaded twice again.

Yes, this is my design as the manifest loaded from a different location could have a different content than the one loaded from the default location. So we only share it in case the resulting URL would be the same.

[boghyon]

Just to note down for other readers what I observed: Since 1.54.0 (and without Component-preload.js), the manifest file is not loaded twice anymore but only when there was a name provided in the component creation. E.g.:

sap.ui.component({
  name: "...",
  manifest: true
})

If a URL is given instead (manifest: "myPath.json"), the manifest file is loaded twice again.