Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Extension of extended apps via manifest configuration

See original GitHub issue

Given

Looks like extending of extended apps via configuration in manifest doesn’t work properly.

For example:

we have component/application ‘App1’ with controller ‘controller1’
we extend component ‘App1’ with component ‘App2’ and within ‘App2’ we extend controller ‘controller1’ by new controller ‘controller1App2’ by means of configuration in manifest (“sap.ui.controllerExtensions”)
we extend component ‘App2’ with component ‘App3’ and within ‘App3’ we extend controller ‘controller1App2’ by new controller ‘controller1App3’ again by means of configuration in manifest

What is the expected result?

When we run component ‘App3’ both controller extensions ‘controller1App2’ and ‘controller1App3’ are applied.

What happens instead?

The result when we run ‘App3’ that the only configuration from component ‘App2’ will be applied for controller extension. Means only ‘controller1App2’.

At this code below when controller is being initialized the component configs mComponentConfigs has two correct configurations for component ‘App2’ and for component ‘App3’. But they are both correct from if condition point of view and there is no sequence implemented. https://github.com/SAP/openui5/blob/d07a224febb832f74a3662d68fda98e7eb060c15/src/sap.ui.core/src/sap/ui/core/CustomizingConfiguration.js#L58-L63

Could you please check.

*Unfortunately I don’t know how to create easy executable example with several extended apps. If you have any simple example with extended apps (via manifest config) which I can copy and modify might be helpful.

Issue Analytics

State:
Created 3 years ago
Comments:11 (7 by maintainers)

Top GitHub Comments

1reaction

flovogtcommented, Aug 10, 2020

Hi @AndreiLiakhavets , we’ve heard your feedback and added a Restriction section to the document. Screen Shot 2020-08-10 at 12 53 15 See also here https://openui5nightly.hana.ondemand.com/#/topic/c264d66d6e3c4104818bc52c174a000c It will be available with UI5 version 1.81.0. Thanks for your commitment to make the documentation more understandable. All the best, Florian

1reaction

flovogtcommented, Jul 16, 2020

Follow-Up: We’ve enhanced the documentation to distinguish better between the different extension mechanisms https://openui5nightly.hana.ondemand.com/#/topic/c264d66d6e3c4104818bc52c174a000c. Thanks a lot for your opening this issue. Florian