question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[ON HOLD] Include smartedit webApplicationInjector.js in schematics

See original GitHub issue

We need to resolve legal/security issues with webApplicationInjector.js file first:

  • what’s the licence of this file, can we change it?
  • should we cover it in our security guidelines/checks?

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
marlasscommented, Apr 23, 2021

In 3.2 we released @spartacus/smartedit as a standalone package containing the Smartedit integration with spartacus.

In this package under assets directory we ship webApplicationInjector.js file.

Additionally this package have schematics setup. When you run ng add @spartacus/smartedit it will configure integration in your application and add to angular.json assets section of your application build glob that will copy webApplicationInjector.js file when you build application. image

0reactions
artem-zurcommented, Jul 13, 2020

I’d rather not include this as part of schematics, as I believe we need to change the approach here. instead of making the import a blocking JS resource in the application, I rather make it configurable, and load it in a singleton service. We do this similar in the qualtrics integration. The main reason for this is that we don’t like to load this in production. If we make the import part of the index.html, we basically need a public app and a non-public app. This makes deployments unnecessary complicated. The alternative is that the injector JS file is always loaded on production builds.

Hi guys! Any updates on it ?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Overview of the SmartEdit Framework Architecture
Web Application Injector : A JavaScript library that pushes the SmartEdit application and other resources into the website within the SmartEdit container's ...
Read more >
How to configure Hybris smartedit to use spartacus in static ...
This results in HTTP 404, as there is no such file available. I have compiled Spartacus by running. ng build. Currently, my workaround...
Read more >
SmartEdit Integration - Spartacus Documentation - SAP
The following steps are for configuring SmartEdit to work using the SmartEdit feature library. Build your Angular app, adding Spartacus libraries as normal....
Read more >
Connecting SmartEdit to a Spartacus Storefront - SAP ...
Before you can connect, please make sure you have installed SAP ... First, I will copy the SmartEdit file, webApplicationInjector.js, ...
Read more >
spartacus/smartedit
Spartacus Smart Edit can be added to the existing Spartacus application by running ng add @spartacus/smartedit . For more information about ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found