Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

`@sapui5/ts-types-esm` - compile errors with typescript `strict` flag

See original GitHub issue

`tsc` output

node_modules/@sapui5/ts-types-esm/types/sap.ui.comp.d.ts:3412:5 - error TS2416: Property 'getVisibleInFilterBar' in type 'FilterGroupItem' is not assignable to the same property in base type 'FilterItem'.
  Type 'undefined' is not assignable to type '() => boolean'.

3412     getVisibleInFilterBar: undefined;
         ~~~~~~~~~~~~~~~~~~~~~

node_modules/@sapui5/ts-types-esm/types/sap.ui.comp.d.ts:15766:5 - error TS2416: Property 'search' in type 'SmartFilterBar' is not assignable to the same property in base type 'FilterBar'.
  Type '(bSync?: boolean | undefined) => boolean | undefined' is not assignable to type '() => boolean'.
    Type 'boolean | undefined' is not assignable to type 'boolean'.
      Type 'undefined' is not assignable to type 'boolean'.

15766     search(
          ~~~~~~

node_modules/@sapui5/ts-types-esm/types/sap.ui.core.d.ts:33177:5 - error TS2416: Property 'getId' in type 'UIArea' is not assignable to the same property in base type 'ManagedObject'.
  Type '() => string | null' is not assignable to type '() => string'.
    Type 'string | null' is not assignable to type 'string'.
      Type 'null' is not assignable to type 'string'.

33177     getId(): string | null;
          ~~~~~

node_modules/@sapui5/ts-types-esm/types/sap.ui.vtm.d.ts:665:5 - error TS2416: Property 'setTooltip' in type 'Column' is not assignable to the same property in base type 'UI5Element'.
  Type '(sTooltip?: string | undefined) => this' is not assignable to type '(vTooltip: string | TooltipBase) => this'.
    Types of parameters 'sTooltip' and 'vTooltip' are incompatible.
      Type 'string | TooltipBase' is not assignable to type 'string | undefined'.
        Type 'TooltipBase' is not assignable to type 'string'.

665     setTooltip(
        ~~~~~~~~~~

tsconfig

{
    "compilerOptions": {
        "target": "es2018",
        "module": "es2015",
        "moduleResolution": "node",
        "declaration": true,
        "declarationMap": false,
        "skipLibCheck": false,
        "preserveConstEnums": true,
        "sourceMap": false,
        "allowJs": false,
        "strict": true,
        "strictNullChecks": true,
        "strictPropertyInitialization": true,
        "noImplicitAny": true,
        "strictFunctionTypes": true,
        "strictBindCallApply": true,
        "noImplicitThis": true,
        "alwaysStrict": true,
        "noUnusedLocals": true,
        "noUnusedParameters": true,
        "noImplicitReturns": true,
        "noFallthroughCasesInSwitch": true,
        "noUncheckedIndexedAccess": true,
        "forceConsistentCasingInFileNames": true,
        "noPropertyAccessFromIndexSignature": true,
        "noImplicitOverride": true,
        "exactOptionalPropertyTypes": false,
        "allowUnreachableCode": false,
        "stripInternal": false,
        "esModuleInterop": true,
        "rootDir": "./src",
        "outDir": "./dist",
        "noEmit": true,
        "baseUrl": "./",
        "isolatedModules": true,
        "resolveJsonModule": true,
        "typeRoots": ["./node_modules/@types", "./node_modules/@sapui5/ts-types-esm"],
        "paths": {
            "thirdparty/*": ["./node_modules/*"]
        }
    },
    "include": ["./src/**/*", "./types/**/*"]
}

Issue Analytics

State:
Created 2 years ago
Comments:7 (5 by maintainers)

Top GitHub Comments

1reaction

DetachHeadcommented, Feb 4, 2022

all good, i know you guys close issues as soon as they are fixed rather than when the fix is released. as long as it’s been fixed that’s fine with me 😃

1reaction

DetachHeadcommented, Feb 3, 2022

@akudev one of the errors is still there in 1.98.0:

node_modules/@sapui5/ts-types-esm/types/sap.ui.comp.d.ts:15955:5 - error TS2416: Property 'search' in type 'SmartFilterBar' is not assignable to the same property in base type 'FilterBar'.
  Type '(bSync?: boolean | undefined) => boolean | undefined' is not assignable to type '() => boolean'.                                                                                    
    Type 'boolean | undefined' is not assignable to type 'boolean'.                                                                                                                         
      Type 'undefined' is not assignable to type 'boolean'.                                                                                                                                 
                                                                                                                                                                                            
15955     search(                                                                                                                                                                           
          ~~~~~~

can this issue be re-opened or should i raise a new one?