Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Floating Footer for Page component problem

See original GitHub issue

Describe the bug

I just set up new Angular project and I tried to use Page WC and I am getting this behavior you can see on the picture. The floating bar slides from bottom up and stays in header. I just copied example from docs. Not sure if I am missing something ?

To reproduce Steps to reproduce the behavior:

Go to https://github.com/KevinOkamoto/poc-checkout
Clone repo
Run

npm i 
ng serve 
ng serve  ui5-checkout

If I hide footer this is what I get:

Do I need to import some additional styles ? As I see icons are missing too.

Issue Analytics

State:
Created 2 years ago
Comments:5 (5 by maintainers)

Top GitHub Comments

1reaction

petermuessigcommented, May 6, 2021

Just had a look into the example, the height: 100%; is missing for <html> and <body>. IMO, this should be documented for components like the <ui5-page> that the component needs to have a dedicated height and when you want to fill the full page with the page component we should document how to do so with the height style.

Another issue is the height calculation for the header / footer. @Web Components Team: as we allow 0…n HTMLElements to be put into the header or the footer slot, the height calculation needs to work properly.

To import the icons, the documentation is here: https://sap.github.io/ui5-webcomponents/playground/components/Icon/ - do we also have a central documentation for using icons?

0reactions

fkolarcommented, Jun 16, 2021

thank you.