question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Icons are still missing after following migration guide 1.0.0-rc.4 to 1.0.0-rc.5

See original GitHub issue

Describe the bug I have upgraded the ui5-webcomponents version I’m using to 1.0.0-rc.5 and followed the migration guide to adapt the icons. However, my application still doesn’t show them when I load it (I’m using the react wrapper).

Debugging the error, what I found is that two instances of SVGIconRegistry are loaded, one from @ui5/webcomponents-base/dist and other from @ui5/webcomponents-icons/node_modules/@ui5/webcomponents-base/dist. This causes all icons to be registered and then the registry is re-initialized and is empty when the icons are requested by the application.

To reproduce Steps to reproduce the behavior: I’m not sure exactly how to reproduce it, since I followed the instructions on the migration guide and it’s still not working.

Expected behavior I’d like some help identifying a fix for this, or if this is an actual bug of ui5-webcomponents.

Screenshots In my package.json, under dependencies I have this: image

Icon is missing: image

The project has two SVGIconRegistry files: image

One file initializes the registry and is used for loading the icons image

The other file initializes another registry and is used for retrieving the icons image

Context

  • UI5 Web Components version: 1.0.0-rc.5
  • OS/Platform: Windows
  • Browser (if relevant): Chrome

Log output / Any errors in the console

Required icon is not registered. You can either import the icon as a module in order to use it e.g. "@ui5/webcomponents/dist/icons/search.js", or setup a JSON build step and import "@ui5/webcomponents-icons/dist/json-imports/Icons.js".

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:11 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
maitefdupontcommented, Feb 7, 2020

Hi @ilhan007 I just now finished re-installing the dependencies, and apparently everything works as expected! Thanks for your support!

1reaction
maitefdupontcommented, Feb 6, 2020

@ilhan007 I’m not comfortable sharing this information here, so I have mailed you.

Read more comments on GitHub >

github_iconTop Results From Across the Web

'Failed to list versions for com.facebook.react:react-native ...
Could not resolve all files for configuration ':app:debugRuntimeClasspath'. ... project :app > project :react-native-vector-icons
Read more >
8 Ways to Restore Missing Desktop Icons on Windows 11
1. Enable Show Desktop Icons · 2. Check Desktop Icon Settings · 3. Restart Windows Explorer · 4. Rebuild Icon Cache · 5....
Read more >
Icons disappeared after migration - UpdraftPlus
Hi,. We use this plugin a lot for migrations. Now we have an issue. All the icons are disappeared after migrating the website....
Read more >
npm install giving Error after so many WARN - Stack Overflow
If you see the log, for old packages, it gives a Warning and not an Error. The error is actually this line: npm...
Read more >
Web Libraries in Jars - WebJars
AdminBSBMaterialDesign, org.webjars, AdminBSBMaterialDesign, 1.0.7 1.0.5 · AdminLTE, org.webjars, AdminLTE, 3.2.0 3.1.0 3.1.0-rc 3.0.5 3.0.4 3.0.2 3.0.0 ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found