Icons are still missing after following migration guide 1.0.0-rc.4 to 1.0.0-rc.5
See original GitHub issueDescribe the bug I have upgraded the ui5-webcomponents version I’m using to 1.0.0-rc.5 and followed the migration guide to adapt the icons. However, my application still doesn’t show them when I load it (I’m using the react wrapper).
Debugging the error, what I found is that two instances of SVGIconRegistry are loaded, one from @ui5/webcomponents-base/dist and other from @ui5/webcomponents-icons/node_modules/@ui5/webcomponents-base/dist. This causes all icons to be registered and then the registry is re-initialized and is empty when the icons are requested by the application.
To reproduce Steps to reproduce the behavior: I’m not sure exactly how to reproduce it, since I followed the instructions on the migration guide and it’s still not working.
Expected behavior I’d like some help identifying a fix for this, or if this is an actual bug of ui5-webcomponents.
Screenshots In my package.json, under dependencies I have this:
Icon is missing:
The project has two SVGIconRegistry files:
One file initializes the registry and is used for loading the icons
The other file initializes another registry and is used for retrieving the icons
Context
- UI5 Web Components version: 1.0.0-rc.5
- OS/Platform: Windows
- Browser (if relevant): Chrome
Log output / Any errors in the console
Required icon is not registered. You can either import the icon as a module in order to use it e.g. "@ui5/webcomponents/dist/icons/search.js", or setup a JSON build step and import "@ui5/webcomponents-icons/dist/json-imports/Icons.js".
Issue Analytics
- State:
- Created 4 years ago
- Comments:11 (5 by maintainers)
Top GitHub Comments
Hi @ilhan007 I just now finished re-installing the dependencies, and apparently everything works as expected! Thanks for your support!
@ilhan007 I’m not comfortable sharing this information here, so I have mailed you.