question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[sf][a11Y][Button]: Button component can has the "button menu" announcement

See original GitHub issue

Describe the bug Hi Colleague, I am a member of Shanghai WEF team. When we use Button component to open an action sheet, the a11y expect hopes that since this is a button that opens a pop over menu, aria-haspopup=“menu” must be present on the “button” element so that the “button menu” announcement is made by screen reader. However, the Button component of ui5-webcomponents-react doesn’t offer such ability, could you please give us some advice? Thanks!

Isolated Example Here is an isolated example if possible by forking: https://codesandbox.io/embed/affectionate-lichterman-5ee1o2?fontsize=14&hidenavigation=1&theme=dark

To Reproduce Environment & instance: https://qacand.hcm.ondemand.com/login?bplte_company=TALCDC12LilyH

  1. Login -> Go to OMP
  2. Click on ‘.Manage my opportunities’
  3. Tab to the ellipsis

Expected behavior Since this is a button that opens a pop over menu, aria-haspopup=“menu” must be present on the “button” element so that the “button menu” announcement is made by screen reader. This is missing. Refer to this UI5 sample: https://ui5.sap.com/#/entity/sap.m.ActionSheet/sample/sap.m.sample.ActionSheet

Screenshots button_menu_omp

button_menu_omp1

UI5 Web Components for React Information @ui5/webcomponents version: 1.2.1 @ui5/webcomponents-react version: 0.22.2 Browser: Chrome

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (3 by maintainers)

github_iconTop GitHub Comments

0reactions
github-actions[bot]commented, Apr 22, 2022

Hey there, it’s me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Navigation Menu Button Example | APG | WAI - W3C
This example demonstrates the menu button design pattern for a button that displays a menu of link targets. The menu items are made...
Read more >
ARIA: button role - Accessibility - MDN Web Docs
Buttons should always have an accessible name. For most buttons, this name will be the same as the text inside the button, between...
Read more >
Building Accessible Menu Systems - Smashing Magazine
Menu buttons which take the aria-haspopup="true" property do not behave like this. They are activated on click and have no other purpose ...
Read more >
Accessible Icon Buttons - Sara Soueidan
VoiceOver will announce Menu, Button , and the devtools will now indicate that the accessible name of the button was provided by its...
Read more >
Building accessible toggle buttons (with examples for Svelte ...
Toggle buttons might be the biggest missing native HTML element. This post will help you code them right, for all users, in any...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found