question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[SF] [ViewSettingsDialog] [a11y] ViewSettingsDialog accessibility issues

See original GitHub issue

Bug Description

We have found three accessibility defects regarding the ViewSettingsDialog header:

  1. The Title is not announced by the Screen Reader when opening the ViewSettingsDialog (tested with NVDA on Windows 10) Screenshot 2022-01-27 at 18 15 08

  2. The Title text is a ui5-label instead of ui5-title with heading level 2 (h2) Screenshot 2022-01-27 at 18 27 18

  3. When opening the ViewSettingDialog, the focus will go to the header toggle button (which is fine), but then pressing TAB will move the focus to Ascending instead of Sort Order

Expected Behavior

  1. Dialog title should be announced by the screen reader

  2. Heading levels should be consistent

  3. When navigating using keyboard, GroupHeaders shouldn’t be skipped

Steps to Reproduce

These three issues can be found and reproduced using the ViewSettingsDialog example.

Context

  • UI5 Web Components version: 1.0.1
  • OS/Platform: Windows 10 (using NVDA as screen reader)
  • Browser: Google Chrome
  • Affected component: ViewSettingsDialog

Priority

  • Low
  • Medium
  • High
  • Very High

Stakeholder Info (if applicable)

  • Organization: SuccessFactors

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
tsanislavgatevcommented, Mar 2, 2022

Hello @Neeeko @rchrdchn,

All of the issues are now fixed and merged into the master branch.

Best Regards, Tsanislav

0reactions
rchrdchncommented, Mar 16, 2022

Hi @tsanislavgatev - following up on the second issue (https://github.com/SAP/ui5-webcomponents/pull/4827). Please let us know when it will be released. Thank you!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Issue with ViewSettingsDialog
I have a requirement: 1. I am using ViewSettingsDialog where I am filters. 2. The filter Items that I want to show is...
Read more >
ui5/webcomponents: Versions
Full version history for @ui5/webcomponents including change logs.
Read more >
Clear selections from sap.m.ViewSettingsDialog when ...
I am facing the following issue: I have a MasterList in my app with the corresponding component sap.m.ViewSettingsDialog for applying filters, ...
Read more >
7.3 View Settings Dialog Box (Printer Sessions)
Displays this help topic. Setting help. Displays information about the currently selected setting. Related Topics. Printer Emulation Settings ...
Read more >
ui5-webcomponents
ui5-webcomponents repo issues. ... [SF][A11Y][Input] - Input hover style does not match accessibility requirements. rchrdchn.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found