Accuracy for && and ||

Hey, in Java when the coverage is calculated it also checks if only one and or or statement in an if is called. Currently as far as I can see this is not the case for solifidy coverage.

function check(string typeString, uint8 currentType)
        private
        pure
        returns (bool)
    {
        return
            (mapType(typeString, 2) == currentType && mapType(typeString, 4) == currentType ) ||
            (mapType(typeString, 1) == currentType && mapType(typeString, 3) == currentType);
    }

This is satisfied if it returns true and false once, even it has not been triggered with all possible combinations.

Maybe this is also just not displayed in the html report.

[cgewecke]

Hi @rmeissner, thanks for raising this. (FWIW, a similar issue is open at Istanbul here.)

Agree this would increase accuracy and the return snippet you’ve provided is a nice example of where this could be useful.

However, it would be quite difficult to implement with our current design which relies on injecting Solidity event statements into the source code before compilation and tracking the tests’ execution path at the log opcode in the VM. We’re constrained by Solidity’s grammar for conditionals.

That said, we’re working on re-writing solidity-coverage to use in-memory source mappings and passively track the vm’s opcode step with a websocket subscription. This additional level of detail should be possible if that approach succeeds - definitely worth aiming for.

[cgewecke]

Thanks @frangio 😉