Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Upgrade testrpc-sc

See original GitHub issue

There is growing drift between ganache-cli and testrpc-sc.

For example, since 6.1.3, reason string functionality has been added and the client has begun returning false when a view function fails a require gate (instead of throwing a revert error). . .

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:9 (7 by maintainers)

Top GitHub Comments

1reaction

ajhodgescommented, Oct 9, 2018

Hey @cgewecke, I was hoping that due to the discussion in this thread maybe testrpc-sc had been updated to handle reason string functionality in reverts, but as far as I can tell, solidity-coverage v0.5.11 still does not handle revert reason strings. It looks like this was added in ganache-core v2.2.0: https://github.com/trufflesuite/ganache-core/releases/v2.2.0 which was released after the latest release of testrpc-sc.

(I am trying to use solidity-coverage in conjunction with https://github.com/rkalis/truffle-assertions, which tests the reason message included in the revert error message).

1reaction

areacommented, Aug 3, 2018

We’d very much like the reason string functionality in Colony, so I’m taking a crack at this, despite not having done it since it became so complicated! Everything in the upgrading testrpc-sc file seems to be right, apart from the fact that I can’t see how ganache-core-sc depends on provider-engine-sc. Is that no longer the case?

EDIT: The instructions have a push after a rebase, but that’ll require a --force-with-lease, right?

EDIT2: I’m putting coverage-20180803 branches on everything, rather than touching the coverage branches, so I can test everything out without irreversibly ruining something 😛