option.get should not warn if scoped under isDefined

there’s one use case where option.get is safe and reasonable:

def foo(bar: Option[String]) = {
    if (bar.isDefined) {
        val example = bar.get
        // do something with example
    }
    // we no longer care whether it was defined or not
}

The current implementation of this rule forces you use .getOrElse(somethingImpossible) in this context. That seems undesirable to me; things like if (false) and empty else { } are anti-patterns, so using getOrElse when you know the orElse is impossible should be one, too.

[sksamuel]

If you want to side effect only when an option is defined, use .foreach

On Wed, 3 Jun 2020 at 00:45, FFdhorkin [e-mail] wrote:

On a related note:

I doubt you want to get into special handling for individual libraries, but Gatling’s API has an equivalent that is chainable off of ChainBuilder objects, though I’m not sure there’s a generic way to handle it:

chainOfCommands .doIf(bar.isDefined){ // do something with bar.get }

and

chainOfCommands .check( checkIf(bar.isDefined){ // do something with bar.get } )

and

chainOfCommands .doSwitch(bar.isDefined)( // parentheses, not curly braces! true -> bar.get, false -> ??? )

(there’s also doIfEquals, doIforElse, doIfEqualsOrElse, doSwitchOrElse, but they’re all pretty similar to the above. See https://gatling.io/docs/current/general/scenario/)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sksamuel/sbt-scapegoat/issues/108#issuecomment-637968036, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFVSGVUINJCOVYQWQVW57DRUXPODANCNFSM4NRK2NAA .

[mccartney]

Having said that, I believe the warning is a proper one.