Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

file should be avoided in library code

See original GitHub issue

We should be using pkg_resources (or importlib.resources if our min Python version is 3.7) instead of uses of __file__.

$ get grep '__file__' sklearn/
sklearn/__check_build/__init__.py:    local_dir = os.path.split(__file__)[0]
sklearn/datasets/_base.py:    module_path = dirname(__file__)
sklearn/datasets/_base.py:    module_path = dirname(__file__)
sklearn/datasets/_base.py:    module_path = dirname(__file__)
sklearn/datasets/_base.py:    module_path = dirname(__file__)
sklearn/datasets/_base.py:    module_path = dirname(__file__)
sklearn/datasets/_base.py:    base_dir = join(dirname(__file__), 'data/')
sklearn/datasets/_base.py:    with open(dirname(__file__) + '/descr/linnerud.rst') as f:
sklearn/datasets/_base.py:    module_path = dirname(__file__)
sklearn/datasets/_base.py:    module_path = join(dirname(__file__), "images")
sklearn/datasets/_california_housing.py:    module_path = dirname(__file__)
sklearn/datasets/_covtype.py:    module_path = dirname(__file__)
sklearn/datasets/_kddcup99.py:    module_path = dirname(__file__)
sklearn/datasets/_lfw.py:    module_path = dirname(__file__)
sklearn/datasets/_lfw.py:    module_path = dirname(__file__)
sklearn/datasets/_olivetti_faces.py:    module_path = dirname(__file__)
sklearn/datasets/_rcv1.py:    module_path = dirname(__file__)
sklearn/datasets/_twenty_newsgroups.py:    module_path = dirname(__file__)
sklearn/datasets/_twenty_newsgroups.py:    module_path = dirname(__file__)
sklearn/datasets/tests/test_openml.py:currdir = os.path.dirname(os.path.abspath(__file__))
sklearn/datasets/tests/test_svmlight_format.py:currdir = os.path.dirname(os.path.abspath(__file__))
sklearn/utils/__init__.py:    root = str(Path(__file__).parent.parent)  # sklearn package
sklearn/utils/_testing.py:        cwd = op.normpath(op.join(op.dirname(sklearn.__file__), '..'))

Issue Analytics

State:
Created 2 years ago
Comments:17 (9 by maintainers)

Top GitHub Comments

2reactions

cmarmocommented, Jul 9, 2021

Hi @devpramod, I believe @jackzyliu is waiting for comments and reviews in #20297 . It would be nice if you comment there rather than starting a new pull request. Thanks!

1reaction

rthcommented, Jun 17, 2021

For future reference: see https://github.com/indygreg/PyOxidizer/issues/69 for more context why using __file__ is problematic.