question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

We should add a folder with airspeed velocity (ASV) benchmarks inside scikit-learn.

ASV benchmarks done by @jeremiedbb exist in https://github.com/jeremiedbb/scikit-learn_benchmarks but they currently don’t get enough exposure (i.e. contributors are not aware about them). I think we should include them e.g. under asv_bench/ folder and remove redundant scripts from benchmarks/ folder.

I just made a PR to pandas, and it’s nice when reviewers can ask to add an ASV benchmark for a PR claiming to improve performance. For this to work they need to be inside the scikit-learn repo. Whether we run them somewhere and where is a secondary concern IMO.

For the docs we can “steal” part of the section from the pandas dev guide https://pandas.pydata.org/docs/development/contributing.html#running-the-performance-test-suite

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Reactions:2
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
jeremiedbbcommented, Apr 7, 2020

applicative = performance in terms of accuracy on challenging datasets. speed = pure speed performance, to work on code optimizations

The benchmark suite allows to do accuracy checks also. For now I just check that some metric (depending on the model) and/or that the predicted values stay exactly the same between 2 commits.

0reactions
jeremiedbbcommented, Apr 24, 2020

I made the changes I wanted. Changes in asv broke a functionality I thought there was no work around but just found one so it’s fine. I opened #17026. Still missing the documentation

Read more comments on GitHub >

github_iconTop Results From Across the Web

Adding a Benchmark Line to a Graph - Stephanie Evergreen
Adding a benchmark line to a graph gives loads of context for the viewer. Here's how to make one right inside Excel. It's...
Read more >
Add benchmarks | Substrate_ Docs - Substrate Documentation
Add benchmarks. This guide illustrates how to write a simple benchmark for a pallet, test the benchmark, and run benchmarking commands to generate...
Read more >
Facebook Ad Benchmarks for YOUR Industry [Data]
Check out the Facebook ad performance benchmarks our clients are seeing, including: Average Click-Through Rate (CTR) on Facebook by industry ...
Read more >
Linkedin Ad Benchmarks 2022 - An Always Up-to-date Guide
Here are the common benchmarks that are essential for Linkedin advertisers. ... Message Ad / Inmail Benchmarks; Linkedin Video Ad Benchmarks ...
Read more >
How to add benchmark products
Add benchmark products. Open the Testdriver Admin Tool, and go to the Products screen. Click on the License tab to see the UL...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found