question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add interval notation for include_boundaries parameter for the function check_scalar

See original GitHub issue

Describe the issue linked to the documentation

This is the current documentation for parameter include_boundaries in the function check_scalar:

“left”: only min_val is included in the valid interval;

“right”: only max_val is included in the valid interval;

“both”: min_val and max_val are included in the valid interval;

“neither”: neither min_val nor max_val are included in the valid interval.

Suggest a potential alternative/fix

Add the following interval notation in the documentation for the function check_scalar:

  • “left” [ , )
  • “right” ( , ]
  • “both” [ , ]
  • “neither” ( , )

Note for Beginners

Here are notes on how to get started:

  1. Read the documentation: https://scikit-learn.org/stable/developers/contributing.html
  2. Read notes on Git: https://www.dataschool.io/how-to-contribute-on-github/
  3. Watch videos: https://www.youtube.com/playlist?list=PLBKcU7Ik-ir-b1fwjNabO3b8ebs9ez5ga
  4. Go through the code base, explore it and find the file(s) where the edits need to be made.
  5. Read Stack Overflow’s “How do I ask a good question?”
  6. Be inclusive in your communications: inclusive language
    • Do not use salutations such as “Hello Sir”, or “Hey guys” (Why: these terms exclude women and non-binary people.)
    • Do not use salutations such as “Hello Sir/Madam” (Why: these terms assume gender is binary, and they exclude non-binary people.)

Note that due to limited resources, it may take many days before we can review your pull request. Please be patient, and if you don’t receive any feedback within two weeks, you can give us a reminder on gitter.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:9 (9 by maintainers)

github_iconTop GitHub Comments

1reaction
glemaitrecommented, Dec 15, 2021

@reshamas @thomasjpfan I think that we can keep the English notation. I hope this is mainly what we used up to now. Since parentheses do not exist in French but that we deal with interval, I think that people will be able to find out.

0reactions
yadav-sachincommented, Dec 13, 2021

@reshamas @thomasjpfan I went ahead and added the English interval notation in the pull request (as I think this notation is more widely used). If the French interval notation is preferred, I will change it accordingly.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Interval Notation - Varsity Tutors
Interval notation is a way of writing subsets of the real number line . A closed interval is one that includes its endpoints:...
Read more >
Intervals and interval notation (video) - Khan Academy
Introducing intervals, which are bounded sets of numbers and are very useful when describing domain and range. We can use interval notation ......
Read more >
Solving Inequalities Interval Notation, Number Line, Absolute ...
This Algebra video tutorial explains how to solve inequalities that contain fractions and variables on both sides including absolute value ...
Read more >
Compose Two Rational Functions then Find the Domain in ...
Learn how to compose two functions where one or both of those ... Compose Two Rational Functions then Find the Domain in Interval...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found