Inconsistent documentation in neighbors/classification.py

Per this line, the shape of the first argument, X, is n_query by n_feature. However, subsequent lines (and the code itself) seem to call it n_samples by n_outputs. The code is pretty self explanatory, but it would be nice that lines 138 and 144 are consistent.

[thomasjpfan]

Closing because the original issue regarding consistency between X and the output is fixed on main:

https://github.com/scikit-learn/scikit-learn/blob/8d6d7d9f408642ae7394801f2d44db62aa0d5b0c/sklearn/neighbors/_classification.py#L574-L581

[fx86]

I can take this up! If this is not already taken up.

ping @jnothman @leotrs

On Thu, 17 Jan 2019 at 8:32 AM, Joel Nothman [e-mail] wrote:

Yes.

On Thu, 17 Jan 2019 at 13:56, fx86 [e-mail] wrote:

X is n_samples by n_features would be more appropriate ? n_outputs sounds like the output of the target column, no ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/scikit-learn/scikit-learn/issues/12995#issuecomment-455024174 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAEz69GGaPUt5iA3A6sC_PjaniJFWg5eks5vD-ZogaJpZM4aDzkF

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scikit-learn/scikit-learn/issues/12995#issuecomment-455024970, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPLM1-Gkkt7Wr7BY6SONtVXOfbfk9-7ks5vD-engaJpZM4aDzkF .

– (Handheld)