Look at lgtm.com alerts for last couple of months

Due to a technical glitch, lgtm.com alerts have not been reported on our pull requests for the last couple of months. They could have caught bugs like #12154.

While most of the alerts added in the last couple of months are to sklearn/externals which we can largely ignore (or we can tell joblib and liac-arff that they have issues), it would be good to look through other alerts in the repo to find any that aren’t false alarms.

A first step for a contributor here would be to sort through https://lgtm.com/projects/g/scikit-learn/scikit-learn and identify alerts that are candidates to be fixed. (I have spotted at least one unused import alert that we can fix.)

[thomasjpfan]

LGTM.com checks are already in the PR checks: https://github.com/scikit-learn/scikit-learn/pull/24051/checks under: “LGTM.com”.

The LGTM.com check breaks CI from time to time because of C++ analysis and the way it needs the base branch to build correctly. For example, https://github.com/scikit-learn/scikit-learn/pull/23493 fixes C++ analysis, but LGTM.com fails because the main branch does not have the fix.

Given that we do not have any C++ or javascript alerts, I tried to turn C++ and javascript off a while ago: https://github.com/scikit-learn/scikit-learn/issues/14025 but there was no way to do it. Currently, I still do not see a way to turn it off for those languages.

TLDR: LGTM.com is already running on PRs and I think it’s still somewhat useful.

[s0]

Ah gotcha 👍