`random_state` must be a RandomState instance

https://github.com/scikit-learn/scikit-learn/blob/4d5407c89fb2b25ef5cba90470cbdaecf10064cc/sklearn/cluster/_kmeans.py#L56

This is a private function, so it’s maybe not a big deal, but I wanted to point out that the parameter random_state to _k_init() must be a RandomState instance, it can not be an integer. So, the documentation of this parameter is wrong on the docstrings of _k_init().

[glemaitre]

yes 👍

On Thu, 2 Jan 2020 at 18:43, Manish Aradwad [e-mail] wrote:

I’ll do this one… Just for clarification, I should change the line random_state : int, RandomState instance to random_state : RandomState instance and update the documentation below it, right??

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/scikit-learn/scikit-learn/issues/16004?email_source=notifications&email_token=ABY32P253PFLQR5GVPPXSQ3Q3YRUTA5CNFSM4KCCTTKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH65LTA#issuecomment-570283468, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABY32P6PN2KEQLIAM2BEZADQ3YRUTANCNFSM4KCCTTKA .

– Guillaume Lemaitre Scikit-learn @ Inria Foundation https://glemaitre.github.io/

[glemaitre]

Closing after merging the PR. Thanks for reporting.