Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove fixes/compat for Python 2

See original GitHub issue

This can be broken up into multiple pull requests.

Remove:

from __future__ imports
sklearn.externals.six
super(cls, self) is now super()
any code explicitly commented to be for Python 2 support
anything else in sklearn.utils.fixes related to this

Admittedly I’m not sure it is wise to rush this change, given that we might still be backporting fixes to 0.20.X for a little while…

Issue Analytics

State:
Created 5 years ago
Comments:16 (16 by maintainers)

Top GitHub Comments

2reactions

rthcommented, Sep 4, 2018

I also can’t wait for this to happen, but I think we might want to wait for the final 0.20.0 release or even 0.20.1 before removing Py2 code to make backports easier.

1reaction

rthcommented, Aug 31, 2020

I think all of the points were indeed addressed here.

@albertvillanova thanks! If you are looking for for another issue to contribute, you can also have a look at stalled PRs starting with those that are short and not too controversial as they are more likely to get merged faster.