Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove validation from `init` and `set_params`

See original GitHub issue

This issue is reserved for the Data Umbrella Africa & Middle East Sprint on October 23, 2021 as a good first issue. For non-sprint contributors, please wait till October 30, 2021 to work on this issue.

Follow up to https://github.com/scikit-learn/scikit-learn/pull/16945

Make sure you have the development dependencies and documentation dependencies installed.
Pick an from the list below and leave a comment saying you are going to work on it. This way we can keep track of what everyone is working on.
Remove the estimator(s) from:

https://github.com/scikit-learn/scikit-learn/blob/d4d5f8c7e02cfaced76757fbf38e21c5b28b67b0/sklearn/tests/test_common.py#L408

Run the test for checking for no validation, which should fail:

pytest sklearn/tests/test_common.py::test_estimators_do_not_raise_errors_in_init_or_set_params

Update the codebase so the above test passes.
Open a Pull Request with an opening message Addresses #21406. Note that each item should be submitted in a separate Pull Request.
Include the function name in the title of the pull request. For example: “ENH Removes validation in __init__ for _______”.

ColumnTransformer
Pipeline, FeatureUnion #21888
FactorAnalysis #21713
FastICA
FeatureHasher #21573
GridSearchCV, HalvingGridSearchCV
KernelDensity
KernelPCA
LabelBinarizer
NuSVC, NuSVR, SVC, SVR, OneClassSVM
RadiusNeighborsClassifier
SGDOneClassSVM: tricky to get right (not a good first issue)
TheilSenRegressor
TweedieRegressor

Estimators on the same line should be fixed together since they share a parent class.

Issue Analytics

State:
Created 2 years ago
Comments:22 (21 by maintainers)

Top GitHub Comments

1reaction

ogriselcommented, Sep 15, 2022

This was the last! Thank you everybody!

1reaction

Haidar13commented, Oct 23, 2021

I will be working on NuSVC, NuSVR, SVC, SVR, OneClassSVM

Top Results From Across the Web

Validating Fields | Lightning Aura Components Developer Guide

Validate user input, handle errors, and display error messages on input fields. Built-in field validation is available for the base components discussed in ......

Angular removing Validators.min from form control validation

Im trying to use clearValidators() to remove the validation but it only removes the required but not the min(0.1).

e.force:navigateToURL: [Cannot read property 'setParams' of ...

This event is handled by the one.app container. It's supported in Lightning Experience, Salesforce1, and Lightning communities. Share. Share ...

Salesforce Lightning Tutorial - Part 5 | Adding Validations

So, let's begin by adding validations in our Lightning Component. Here our main focus is on client side validations only so all this...

Dynamically Add/Remove Validators in Angular Reactive Forms

For this, you might think of adding and removing required validator from “County” ... For e.g., Suppose during form initialization, you set maxLength...