question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Track SLEP10: Add n_features_in_ to all modules

See original GitHub issue

This issue tracks the status of follow-ups of #18514, i.e. the implementation of SLEP10.

According to N_FEATURES_IN_AFTER_FIT_MODULES_TO_IGNORE in test_common.py, as of 96a96f19579c71da80a14f33a15a0402b2f797b4, modules to be n_feature_in_-ified are:

Track documentation status of n_features_in_ , see N_FEATURES_MODULES_TO_IGNOREin test_docstring_parameters.py, start was #19351. Note that existing alternatives like n_features_ attributes have to be properly deprecated:

Note: for meta-estimators it is better to delegate feature consistency validation to the inner base estimators.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

3reactions
ogriselcommented, Jun 15, 2021

Yeah!!!

1reaction
thomasjpfancommented, Feb 4, 2021

How do we document n_features_in_? In the merged PRs, I don’t see entries as attribute in the docstrings.

I think we should add them to the docstring. I opened https://github.com/scikit-learn/scikit-learn/pull/19351 to start the process of documenting this.

Another question is how we want to deal the attribute n_features_ in BaggingClassifier. Do we want to deprecate that one or do we just replace it by n_features_in_?

I would say to deprecate it.

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found