question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update contributing, video section, add note on master to main

See original GitHub issue

Describe the issue linked to the documentation

Videos on contributing to scikit-learn reference were created prior to renaming the branch name, and so refer to master, not main

Suggest a potential alternative/fix

In this file, under “Video Resources” section: https://github.com/scikit-learn/scikit-learn/blob/d01014c3198aafa336d9f8ed306f292d68c4a886/doc/developers/contributing.rst

add a note: Note: In January 2021, the default branch name for changed from master to main for scikit-learn to remove any unnecessary references to slavery and replace them with more inclusive terms. These videos were created prior to the renaming of the branch. For contributors who are viewing these videos to set up their working environment and submitting a PR, master should be replaced to main.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:1
  • Comments:10 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
reshamascommented, Apr 23, 2021

@cesar-ca You are right about the link (not sure where I got that link from?).

The fix here would be to update the file contributing.rst under “Video Resources” section, adding this note:

Note: In January 2021, the default branch name for changed from master to main for scikit-learn to remove any unnecessary references to slavery and replace them with more inclusive terms. These videos were created prior to the renaming of the branch. For contributors who are viewing these videos to set up their working environment and submitting a PR, master should be replaced to main.

The goal here is that when contributors are setting up their environment, they should replace master to main.

It will be a while before @amueller and I record new videos.

0reactions
PSSF23commented, May 1, 2021

Sorry for the people who came before me, but a doc change doesn’t need that long to implement~

Read more comments on GitHub >

github_iconTop Results From Across the Web

Contributing to projects - GitHub Docs
Learn how to contribute to a project through forking. ... In this article ... Note: If you want to copy additional branches from...
Read more >
Easily rename your Git default branch from master to main
Updating local clones · Go to the master branch · Rename master to main locally · Get the latest commits from the server...
Read more >
2.2 Git Basics - Recording Changes to the Repository
Note. GitHub changed the default branch name from master to main in mid-2020, ... git add CONTRIBUTING.md $ git status On branch master...
Read more >
How to make your first pull request on GitHub - freeCodeCamp
Pull requests are the way we contribute to group projects or open source ... Now we have set up a copy of the...
Read more >
Wiki - GitLab Docs
Add a welcome message for your home page in the Content section. You can always edit it later. ... GitLab tracks wiki creation,...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found