Can mongo_world=True work with missing_accessor=True?

AFAIU, in as_marshmallow_schema, one can pass

missing_accessor=True, mongo_world=True

But it is bound to fail, because schema_from_umongo_get_attribute expects obj to be an object, not a dict.

def schema_from_umongo_get_attribute(self, attr, obj, default):
    ret = MaSchema.get_attribute(self, attr, obj, default)
    if ret is None and ret is not default and attr in obj.schema.fields:
        raw_ret = obj._data.get(attr)
        return default if raw_ret is missing else raw_ret
    else:
        return ret

Shouldn’t this be prevented? Like, by setting missing_accessor to False when mongo_world is True?

[touilleMan]

I’m also realizing that I might lack this feature when serializing data from Mongo world. It makes output a bit different depending on the path used (directly from DB or through OO world).

Mongo world is supposed to always return you the raw data, so there is no need to provide a custom get_attribute. Thus Mongo world and OO world should provide the same consistent behavior (i.e. missing is handled by marshmallow-pure schema)

Currently, schema_from_umongo_get_attribute is broken in Mongo world

As stated above: it is not broken, it is not needed 😄

Given your summarize, I think we agree missing_accessor is doing more harm than good so I pushed a new version removing it. Beside, this feature should work with Mongo world as well as OO world, so open an issue if it’s not the case 👍

[lafrech]

OK, I get it. Removing it is the right thing to do.

Thanks.