JSONRequest naming issue
See original GitHub issueA few months ago JSONRequest
was added to Scrapy (https://github.com/scrapy/scrapy/pull/3505) and released with the new Scrapy version 1.7.
However, I realized that the name is not in accordance with the rest of the classes: HtmlResponse
, XmlResponse
, XmlRpcRequest
.
It should be named:
JsonRequest
.
I know it isn’t backward-compatible, but as it’s a really recent addition and Scrapy 2.0 is on the way it could be fixed.
Issue Analytics
- State:
- Created 4 years ago
- Comments:11 (11 by maintainers)
Top Results From Across the Web
JSON request formatting issue - java - Stack Overflow
I guess the reason why you're using @JsonProperty is that the name of the parameters in your json (FirstName, LastName) are different from...
Read more >Issue mapping JSON request | Support Center
Hi, I've this particular issue mapping json attribute of a REST ... the only reason is that I know that Pega naming convention...
Read more >Need help on the JSON request - Getting error with Azure ...
I am working on the web-service which accepts JSON request. ... please check the below JSON request and let me know if there...
Read more >JSON request message for Name Value pair field - ServiceNow
Hi, I have exposed REST API for POST method to be able to create records of the data received from ext system on...
Read more >Getting issue with passing string variable in JSON request
Getting issue with passing string variable in JSON request [closed] ... and without having to enclose JSON field names in quotes.
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
As all the classes in Scrapy starting with “JSON” (
JsonLinesItemExporter
,JsonItemExporter
andJsonWriterPipeline
) use that format, it could be a good idea.If you all want to proceed I can re-open the original PR and adding the code to deprecate that class.
@kmike at https://github.com/scrapy/scrapy/pull/3930#issuecomment-519518983