Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Random(?) test_crawler.py failure on Travis

See original GitHub issue

Every now and then the Travis build fails on tests.test_crawler.CrawlerRunnerTestCase.test_deprecated_attribute_spiders, I’m not sure why. Some examples:

PS: Sorry, I feel bad for ignoring the bug report template, but I felt like it didn’t apply in this case.

Issue Analytics

State:
Created 4 years ago
Reactions:2
Comments:8 (8 by maintainers)

Top GitHub Comments

1reaction

s-sanjaycommented, Oct 6, 2019

the flakiness is happening due to this

{message : ResourceWarning('unclosed file <_io.BufferedReader name=30>',), category : 'ResourceWarning', filename : '/Users/sanjay/nobackup/scrapy/.tox/py36/lib/python3.6/copy.py', lineno : 239, line : None}
{message : ResourceWarning('unclosed file <_io.BufferedReader name=25>',), category : 'ResourceWarning', filename : '/Users/sanjay/nobackup/scrapy/.tox/py36/lib/python3.6/copy.py', lineno : 239, line : None}
{message : ScrapyDeprecationWarning('CrawlerRunner.spiders attribute is renamed to CrawlerRunner.spider_loader.',), category : 'ScrapyDeprecationWarning', filename : '/Users/sanjay/nobackup/scrapy/tests/test_crawler.py', lineno : 172, line : None}

These warnings ResourceWarning('unclosed file <_io.BufferedReader name=30> are the reason the tests are failing. Every run, the filename is changed and I still have to figure out who is opening these files and everytime it blames deepcopy module.

0reactions

Gallaeciocommented, Nov 1, 2019

@s-sanjay I was suggesting that as a temporary measure, to avoid new contributors from getting hit by this and us having to explain to them that the issue is in Scrapy and not in their changes.

In any case, #4095 should have fixed the actual issue.