set_crawler not working neither warning deprecated?

class test(scrapy.Spider):
    name = 'test'

    start_urls = ['http://httpbin.org']

    def set_crawler(self, crawler):
        super(test, self).set_crawler(crawler)
        print(999999999999999)

    def parse(self, response):
        print('ok')

considering fixing or removing it?

[kmike]

The code never issues a warning, because it is not an user who should call set_crawler - Scrapy used to call it. Now Scrapy uses from_crawler method instead of set_crawler. If user defined set_crawler method in a Spider subclass, this method just stopped working as a mean to do some work on spider init, without any deprecation warnings - warning is only displayed when a method is called, but Scrapy stopped to call it. This happened a while ago though, I don’t think we need to fix that.

[NewUserHa]

don’t remember, maybe from scrapy’s source code or other’s comments. I might open this issue to say there's old code need to remove. but it’s not in the master branch now.

maybe mistake and this issue can be closed. thanks.