Httpclient opening too many files on linux

Hello.

I’ve started using this lib to do Oauth in a production enviroment, and since then we are facing a problem.

The app, from times to times is having an Too Many Open Files exception. We have checked and the class that is opening the files is in the dependency httpclient-nio, called by the OauthService here.

Somehow, i think this lib is opening files for each http async request, and never closes it.

Here is how i’m calling the lib:

LoginController.java:

public class LoginController implements Serializable {
	OAuth20Service oauthService = new ServiceBuilder(OAuthADFSApi.instance().getClientId())
			.apiSecret(OAuthADFSApi.instance().getSecret())
			.callback(OAuthADFSApi.instance().getCallback())
			.httpClientConfig(ApacheHttpClientConfig.defaultConfig())
			.build(OAuthADFSApi.instance());

...

public void callbackOAuth() throws IOException {
		FacesContext context = FacesContext.getCurrentInstance();
		HttpServletRequest req   = (HttpServletRequest) context.getExternalContext().getRequest();
		HttpServletResponse resp = (HttpServletResponse) context.getExternalContext().getResponse();

		String error = req.getParameter("error");
		if ((null != error) && ("access_denied".equals(error.trim()))) {
			HttpSession sess = req.getSession();
			sess.invalidate();
			resp.sendRedirect(req.getContextPath());
			return;
		}

		String code = req.getParameter("code");
		OAuth2AccessToken accessToken = null;
		try {
			accessToken = oauthService.getAccessTokenAsync(code).get();
			JsonObject profile = (JsonObject) new JsonParser().parse(accessToken.getRawResponse());
			DecodedJWT jwt = JWT.decode(profile.get("id_token").toString());

			String login = extrairLoginDosClaims(jwt);

			Usuario usuario = usuarioService.logar(login, null);
			contextFacade.setUsuarioLogado(usuario);
			resp.sendRedirect("pages/home.xhtml");
		} catch (Exception e){
			ELContext elContext = context.getELContext();
			ValueExpression erroValueExpression = context.getApplication().getExpressionFactory().createValueExpression(elContext, "#{erroController}", ErroController.class);
			ErroController erroController = (ErroController) erroValueExpression.getValue(elContext);
			erroController.setDetalhesMensagem(e.getCause() != null? e.getCause().getMessage() : e.getMessage());
			context.getExternalContext().redirect("erro.xhtml");
		}
	}

Should i be calling any “close” or anything on this lib? Or am i doing something wrong?

Thanks

[kullfar]

session scope - that’s the reason I think. You do not need so many http clients 😉 You should make oauthService a singleton either create http client once and use it for all OAuthServices as in “any externally created HTTP client example” (https://github.com/scribejava/scribejava/blob/master/scribejava-apis/src/test/java/com/github/scribejava/apis/examples/VkontakteExternalHttpExample.java)

[kullfar]

welcome. as for apache lib, it shouldn’t close their files. It’s their feature. to reuse already opened files, connections, etc. to save cpu/memory and other resources.

It’s not a cheap operation to create http client and it’s extra and redundant spend of resource to create such powerful http client for just one http request.