Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

API query params should use `+` not `%20` for spaces

See original GitHub issue

Description

Currently, hitting the API with a properly encoded query parameter will return a 400 when spaces are encoded as +. This is not only valid encoding, but the preferred encoding as per the current HTTP spec. The official Java URLEncoder, for which I am using to build out a program that interacts with the API, follows this spec for application/x-www-form-urlencoded and only encodes spaces as +.

Version

Commit: 4f654b98c31c33cafc50785d0c0a7fb4a7dbe859

Steps to Reproduce

Hit the api with something like http://localhost:5055/api/v1/search?query=Matrix+Reloaded

Expected Behavior

I expect to get search results and not an error

Issue Analytics

State:
Created 2 years ago
Comments:9 (4 by maintainers)

Top GitHub Comments

1reaction

djeis97commented, Sep 19, 2021

Wouldn’t URLs be more correct here than URIs though? i.e. shouldn’t RFC1738 take precedence for a web API over RFC3986?

0reactions

stale[bot]commented, Nov 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.