Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Easy way to set defaults

See original GitHub issue

I’m using this great lib in a bigger project, and I don’t want to pass options to all instanciations, so I created a custom override similar to how it’s recommended in the babel plugin readme.

But in order to make it work also with instaneceof checks and so on, it got a bit complicated: https://gist.github.com/TeNNoX/92770bba1457de1a221bc5ca1462a6cb

Wouldn’t it be possible to just add a currency.setDefaults(...)?

Issue Analytics

State:
Created 3 years ago
Comments:6

Top GitHub Comments

3reactions

overthemikecommented, May 4, 2021

Pretty quick example PR of how to go about this ^

0reactions

tennoxcommented, May 4, 2021

@Gibbo3771

Maybe you need to provide an example of why you would need to do an instanceof check?

normal code… To check if an object stored somewhere or passed to a function is a Currency object.

But I’m not involved with the project anymore, just think it’s a decent feature which should be possible without a wrapper type that makes typescript usage complicated.