Python3 Compatibility and unresolved references

Could you consider Python 3 compatibility like the following code? I tried to fix the code, but Python 2 dependencies was too deep so I gave up. Also I found some unresolved references in transform_rows(refers idx) and migrate(refers destination) functions.

import six
import decimal
import datetime


def _generate_literal_value_for_csv(value, dialect):
    dialect_name = dialect.name.lower()

    if isinstance(value, six.string_types):
        if dialect_name in ['sqlite', 'mssql']:
            # No support for 'quote' enclosed strings
            return "%s" % value
        else:
            value = value.replace('"', '""')
            return "\"%s\"" % value
    elif value is None:
        return "NULL"
    elif isinstance(value, bool):
        return str(int(value))
    elif isinstance(value, six.integer_types):
        return str(value)
    elif isinstance(value, float):
        return str(value)
    elif isinstance(value, decimal.Decimal):
        return str(value)

<bountysource-plugin>

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource. </bountysource-plugin>

[seanharr11]

I’ve got the code about 50% ported to Python3, just need a day or 2 to finish up.

Are you saying that the undefined references were only breaking in Python3? And it Python2.7?

[seanharr11]

@gb-ita @tpow if you guys can both continue to work on @tpow’s great start to unit tests, I will take a stab at setting some functional tests up (I need to get clever with Docker and licensing when trying to deploy Oracle and SQL Server for testing).