Change Detection runs all time even if map is not present

The issue is than if you have <agm-map> in component with *ngIf on it, the change detection runs every second after it is shown.

Steps to reproduce and a minimal demo of the problem

I created repo for reproduction.

What steps should we try in your demo to see the problem?

1. Clone the repo.
2. Put your API_KEY to app.module.ts.
3. Run with ng serve
4. Open the console window.
5. Click on Show/Hide button - Map hides and change detection runs only couple of times and then stops
6. Click on Show/Hide button again - Map is shown and in console the change detection logs keep running / there is also so much change detection running if you hover over

angular2 & angular-google-maps version

"@agm/core": "1.0.0-beta.0"

[ByrelMitchell]

@SebastianM

I believe I tracked down where this issue is coming from. In the constructor for FitBoundsService, there’s an observable pipeline definition which basically samples the includeInBounds$ observable based on a variable timer, and then maps that onto a generation of the bounds.

The first problem is the internal timer is triggering angular change tracking every time it fires (by default, 5 times per second) regardless of whether the observable it’s sampling has a new value.

The second is that the FitBoundsService is not disposed on map-hide, but a new instance is created the next time the map is shown. This leak leads to very bad performance if change checking is remotely expensive.

I’m fairly new the RxJS and the Angular change-tracking system, so I’m not at all sure what the appropriate fix is here. Hopefully finding the problem will make this easy for someone more skilled than me.

[JiriBalcar]

Any update on this issue?