Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Directive outputs missing ((drag) and (dragStart) for agm-marker)

See original GitHub issue

Issue description Only the directive output (dragEnd) is working for agm-marker, not (drag) or (dragStart)

I noticed that in node_modules/@agm/core/directives/marker.d.js there is only dragEnd: EventEmitter<MouseEvent>; and not EventEmitters for drag and dragStart although they are in the documentation. Maybe not being compiled properly?

Issue Analytics

State:
Created 5 years ago
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

jczachariacommented, Mar 2, 2019

I figured it out. I had a difficult time installing this repo because it has failing tests… and I didn’t realize it.

In case anyone has issues with it: Clone the repo, then run npm install then npm run build and where ever it fails, just comment out the failing tests… so I guess another issue should be opened if not already that:

packages/js-marker-clusterer/services/managers/cluster-manager.spec.ts(221,53): error TS2322: Type 'Promise<{ setCalculator: Mock<any, any>; }>' is not assignable to type 'Promise<MarkerClustererInstance>'.
  Type '{ setCalculator: Mock<any, any>; }' is missing the following properties from type 'MarkerClustererInstance': zoomOnClick_, averageCenter_, imagePath_, minimumClusterSize_, and 20 more.

0reactions

jczachariacommented, Apr 13, 2019

@rapw3k, yes I did. So, any *.spec.ts is a unit test file. Therefore you don’t need it to compile the code. That error is just telling you that you have a failing unit test so you just need to comment them out to get the code to compile. Try commenting out everything describe('set calculator', () => { ... see how that works for you.