yarn upgrade to 9.4.0 fails with ENOTDIR

Problem

Upgrading react-ace from 9.3.0 to 9.4.0 fails if using yarn. Apparently one of the paths in node_modules/react-ace changed from file to dir. Erasing node_modules and reinstalling dependencies seems to fix the issue, but is not ideal (multiple devs machines, CI cache, etc.).

yarn upgrade v1.22.5
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
error An unexpected error occurred: "ENOTDIR: not a directory, lstat '/...../node_modules/react-ace/dist/react-ace.min.js/main.js.LICENSE.txt'".

Sample code to reproduce your issue

yarn init
yarn add react-ace@9.3.0 react react-dom
yarn upgrade react-ace@9.4.0

References

Progress on: #

[CyrilQuandalle]

I just had to remove my node_modules, reinstall them and it was solved

[jamgregory]

This issue seems to be caused by an older(?) version of react-ace having react-ace.min.js as a file, not a folder. Seemingly during the upgrade the old file isn’t removed, which is why this is failing.

Our simplest fix was to check for the existence of that file and remove react-ace before reinstalling:

[ -f 'node_modules/react-ace/dist/react-ace.min.js' ] && rm -rf node_modules/react-ace && yarn install