Question regarding the low power scan option
See original GitHub issueHi,
I have a question regarding the low power scan option if you don’t mind me asking.
Recently, the label text for the option was changed from If enabled bluetooth low power scan will be used to discover nearby AirTags!<b>WARNING</b>: This could cause that some devices won\'t be discovered!
to If enabled, Bluetooth Low Energy scanning will be used to discover nearby AirTags!<b>WARNING</b>: Without this option, some devices might not be discovered!
.
However, according to the code, Bluetooth Low Energy is used regardless of this option, and the low power scanning mode is used when this option is enabled. https://github.com/seemoo-lab/AirGuard/blob/4a29baeb9623e5e7ed5a49b65be3b9008191e305/app/src/main/java/de/seemoo/at_tracking_detection/detection/ScanBluetoothWorker.kt#L7 https://github.com/seemoo-lab/AirGuard/blob/4a29baeb9623e5e7ed5a49b65be3b9008191e305/app/src/main/java/de/seemoo/at_tracking_detection/detection/ScanBluetoothWorker.kt#L154-L161
So, it seems to me that the label should say If enabled, low power scanning mode will be used to discover nearby AirTags! <b>WARNING</b>: When this option is enabled, some devices might not be discovered!
. Can someone please confirm if this is correct? Also, please let me know if you want me to open a PR to make the change.
Issue Analytics
- State:
- Created 2 years ago
- Reactions:6
- Comments:9 (6 by maintainers)
Top GitHub Comments
To bring some progress into this issue I will sum up the ideas we had so far. Please tell me if you think my suggestion should be changed in some way or if it’s ready for a PR!
Current text (as of v1.2)
@aforemendude
@lenhart
My suggestion to combine all of those ideas
@DrMaxNix we try to align pull-requests with our feature releases. So we are currently working on an enhanced device detection and we will add the pull requests in this release 😊