Support Http Proxy

Axios works with http proxies, but this library doesn’t expose a way to configure the http proxy setting, at least as far as I can tell. I can make this work by doing the following:

// hackily import axios out of the analytics-node module
import analyticsAxios from 'analytics-node/node_modules/axios';
analyticsAxios.defaults.proxy = {
  host: 'x.x.x.x',
  port: 1234,
};

and in package.json:

  "resolutions": {
    "analytics-node/axios": "^0.19.0"
  }

Axios before 0.19.0 has a bug with https proxies, so I needed to upgrade the version of axios used by analytics-node to 0.19.0, since the currently published version is not on 0.19.0 yet.

Is there a less hacky way to accomplish this?

[pbassut]

You’re spot on. Likely a merging error. We’ll fix it ASAP

[igorantun]

@pbassut Although this PR allows passing an axios instance/options to this.axiosInstance, it doesn’t seem to be used later on. (I couldn’t find any occurence of this.axiosInstance outside the constructor)

Apparently it’s this.axiosClient that is actually used: (https://github.com/segmentio/analytics-node/blob/master/index.js#L290) and it receives neither the instance or the options passed to the constructor: https://github.com/segmentio/analytics-node/blob/master/index.js#L56

Am I missing something? Thanks for looking into this 😃