Menu Item when using React Router Link: PropType error and aggressive styling

One issue and one annoyance.

1 - Warning: Failed prop type: Invalid prop 'is' supplied to 'MenuItem' 2 - Doing this with a Menu.Item renders the menu with an underline and coloured like an anchor. Really it should still be styled as a menu-item and not a link. I can override it manually but thats a pain.

Code:

  <Menu.Item
    is={Link}
    to="/settings/"
    icon="settings"
  >
    Settings
  </Menu.Item>
</Menu>

Image:

[cstrat]

Sorry to spam this one issue thread with other comments, but I found why the page is jumping around.

I am pretty sure it is to do with the popover giving the menu button focus on close. Are you be open to having a flag on the popup to bypass this behaviour? If so, I might try doing a PR.

Pretty sure this is what is causing the jump: https://github.com/segmentio/evergreen/blob/master/src/popover/src/Popover.js#L193

Having this function be conditional this.bringFocusBackToTarget() on a new flag passed to Popover might solve it. https://github.com/segmentio/evergreen/blob/master/src/popover/src/Popover.js#L254

[Chrischuck]

@cstrat You shouldn’t have to mess with ts all the src code is in js! It’s a little tricky to figure out how the theming/styling works under the hood though.