[🐛 Bug]: Contained Firefox can't be used on MacOS

What happened?

For the project https://github.com/robocorp/rpaframework/ we’re installing an isolated Firefox and adding that to the path. But because as seen here https://github.com/SeleniumHQ/selenium/blob/dab928e6ac2c270b03d0199f381950c998c3f8b0/py/selenium/webdriver/firefox/firefox_binary.py#L152 the path for MacOS is hardcoded and not searched for in $PATH, Selenium will never find and use that version.

How can we reproduce the issue?

Install Firefox on MacOS in a different path. Add it to the $PATH global variable and try to use Selenium against it. Selenium will fail, not being able to find Firefox.

Relevant log output

SessionNotCreatedException: Message: Expected browser binary location, but unable to find binary

Operating System

MacOS Monterey 12.3

Selenium version

3.141.0 (but based on the code seems like it should be on all versions)

What are the browser(s) and version(s) where you see this issue?

Firefox 98, 99 and 100

What are the browser driver(s) and version(s) where you see this issue?

GeckoDriver 0.30.0

Are you using Selenium Grid?

No response

[bogdancondurache]

Even if we rework the logic and follow your comments, or if we simply remove the path for macOS, GeckoDriver still will use this path as they know better the default locations.

I’m not sure the problem is in GeckoDriver. This works well on Windows and Linux because (I assume) Gecko calculates the paths properly.

Also, which are these ones?

by default it should be detected from the standard locations

Usually the convention is to take each folder from $PATH in order and try to use the binary from there, that’s why the order is important. From what I see, this is done by Selenium on Linux using the which method here: https://github.com/SeleniumHQ/selenium/blob/dab928e6ac2c270b03d0199f381950c998c3f8b0/py/selenium/webdriver/firefox/firefox_binary.py#L211

I think this should be the best approach for MacOS as well, if the binary couldn’t be found in the path currently hardcoded: https://github.com/SeleniumHQ/selenium/blob/dab928e6ac2c270b03d0199f381950c998c3f8b0/py/selenium/webdriver/firefox/firefox_binary.py#L153

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.