[🐛 Bug]: Wrong type for WebElement.get_property

What happened?

This is similar issue to #10623

In this case it’s not so straightforward. The WebElement.get_property declare return value type as str. It is true in many cases but if you try to get property ‘parentElement’ (see example below), then the return value is WebElement. But mypy (PyCharm and other linters) complains that result of get_property is always str. Can you declare return type of get_property as Union of all possible types, which the method can return?

How can we reproduce the issue?

from chromedriver_binary.utils import get_chromedriver_path
from selenium import webdriver
from selenium.webdriver.common.by import By
from selenium.webdriver.remote.webelement import WebElement


def test():
  driver = webdriver.Chrome(executable_path=get_chromedriver_path() + '/chromedriver')
  driver.get('http://www.example.com/')
  element = driver.find_element(by=By.TAG_NAME, value='h1')
  parentElement: WebElement = element.get_property('parentElement')
  print(type(parentElement))


if __name__ == '__main__':
  test()

Relevant log output

no log needed

Operating System

Gentoo Linux

Selenium version

Python 4.1.5

What are the browser(s) and version(s) where you see this issue?

not relevant

What are the browser driver(s) and version(s) where you see this issue?

not relevant

Are you using Selenium Grid?

No response

[eNcacz]

@titusfortner I think this list is not enough. For example

• clientHeight property is returned as int
• fooBar property is returned as NoneType
• childNodes property is returned as list

Just put these names to the example above to test it.

So I think it will be better to use Optional[Union[str, int, bool, WebElement, dict, list]]

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.