Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[Popup] `hideOnScroll` doesn’t work with `on: manual`

See original GitHub issue

There seems to be problems when using popup with on property set to manual. It does not hide on scroll even if it is set to true, with/without scrollContext set. It does not hide on outside click even when closable property is set. And when I specify hoverable it rather hides the popup after it is hovered and then re position cursor somewhere else. It feels completely broken with manual show/hide option or am I missing something here?

Issue Analytics

State:
Created 7 years ago
Comments:11 (5 by maintainers)

Top GitHub Comments

2reactions

awgvcommented, Mar 16, 2017

@Prabhakar-Poudel If you don’t want your popups be destroyed, use pre-existing HTML, or set preserve to true.

I assume how popup appears hover/click/focus/manual should have nothing to do with what the behavior of popup is. Both are independent elements and should have their own properties.

'manual' setting implies that a developer controls when and how to show or hide a popup, and a 'manual' popup will never close until a developer tells it to, rendering hoverable: true useless.

0reactions

stale[bot]commented, Jun 5, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!