Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Closing a nested modal that has a canvas element closes the parent modal as well

See original GitHub issue

Steps

make nested modals with a button to close the inner one
put a canvas element in the child modal
clicking the nested modal’s close button closes the parent modal as well

Expected Result

closing the nested modal shouldn’t close the parent modal

Version

0.79.1

Testcase

https://codesandbox.io/s/znx91x17q4

Issue Analytics

State:
Created 5 years ago
Comments:13 (3 by maintainers)

Top GitHub Comments

1reaction

levithomasoncommented, Apr 27, 2018

I see. Thank you for pushing the issue a bit as I was not only wrong about the canvas but also about the order of the state updates. Apologies!

It seems any other element besides a canvas (e.g. <p />) does not cause this problem. Moreover, placing the canvas anywhere else, besides inside the second modal, also does not cause this problem.

This smells like a React issue but I’d really like to know why the <canvas /> element is magical and why it must be a child of the second modal. This just seems so strange.

0reactions

layershiftercommented, Jan 28, 2019

https://codesandbox.io/s/my8lw043op

Tested with latest SUIR and React, works as it should 🌟