Modals with `dimmer: false` throw an exception in 0.78.3
See original GitHub issueSteps
- Add modal with these props:
dimmer: false
Expected Result
No exception will be thrown when the modal is shown.
Actual Result
An exception is thrown, likely due to the changes made in #2407 (the exception happens after upgrading to 0.78.3):
Uncaught DOMException: Failed to execute 'add' on 'DOMTokenList': The token provided ('function wrapper() {
var length = arguments.length,
args = Array(length),
index = length;
while (index--) {
args[index] = arguments[index];
}
if (isCurried) {
var placeholder = getHolder(wrapper),
holdersCount = countHolders(args, placeholder);
}
if (partials) {
args = composeArgs(args, partials, holders, isCurried);
}
if (partialsRight) {
args = composeArgsRight(args, partialsRight, holdersRight, isCurried);
}
length -= holdersCount;
if (isCurried && length < arity) {
var newHolders = replaceHolders(args, placeholder);
return createRecurry(
func, bitmask, createHybrid, wrapper.placeholder, thisArg,
args, newHolders, argPos, ary, arity - length
);
}
var thisBinding = isBind ? thisArg : this,
fn = isBindKey ? thisBinding[func] : func;
length = args.length;
if (argPos) {
args = reorder(args, argPos);
} else if (isFlip && length > 1) {
args.reverse();
}
if (isAry && ary < length) {
args.length = ary;
}
if (this && this !== root && this instanceof wrapper) {
fn = Ctor || createCtor(fn);
}
return fn.apply(thisBinding, args);
}') contains HTML space characters, which are not valid in tokens.
at eval (webpack-internal:///../../node_modules/semantic-ui-react/dist/es/addons/MountNode/lib/handleClassNamesChange.js:26:27)
at arrayEach (webpack-internal:///1165:15:9)
at forEach (webpack-internal:///418:38:10)
at handleClassNamesChange (webpack-internal:///../../node_modules/semantic-ui-react/dist/es/addons/MountNode/lib/handleClassNamesChange.js:25:56)
at NodeRegistry.emit (webpack-internal:///../../node_modules/semantic-ui-react/dist/es/addons/MountNode/lib/NodeRegistry.js:36:5)
at MountNode.componentWillMount (webpack-internal:///../../node_modules/semantic-ui-react/dist/es/addons/MountNode/MountNode.js:61:22)
at callComponentWillMount (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:6370:14)
at mountClassInstance (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:6435:7)
at updateClassComponent (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:7840:9)
at beginWork (webpack-internal:///../../node_modules/react-dom/cjs/react-dom.development.js:8225:16)
Version
0.78.3
Testcase
(will add a pen later today when I get time)
(cc @mbestwick)
Issue Analytics
- State:
- Created 6 years ago
- Comments:6 (1 by maintainers)
Top Results From Across the Web
How to Throw Exceptions in Python - Rollbar
Python throws the TypeError exception when there are wrong data types. Similar to TypeError, there are several built-in exceptions like:.
Read more >try-catch - C# Reference - Microsoft Learn
When an exception is thrown, the common language runtime (CLR) looks for ... If the exception filter returns false, then the search for...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
I’ve found the issue on my side - @beaugunderson I would advice to check if you used
LodashModuleReplacementPlugin
. In my case this was plugin that broke something forsplit
import oflodash/fp
@bytasv ah, thank you! we do use
LodashModuleReplacementPlugin
and have encountered issues like this from time to time, usually fixed by enabling whichever flag inLodashModuleReplacementPlugin
fixes it… but since this is the third or fourth time this plugin has broken something maybe it’s time for us to get rid of it 😃