Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Popup: triggers that do not spread props do not work

See original GitHub issue

Steps

Create a stateless component.
Pass it to Popup as the trigger prop.

Expected Result

Get the popup when mousing over the trigger component.

Actual Result

Don’t get a popup when mousing over the trigger component.

Version

0.64.2 (master)

Testcase

http://codepen.io/anon/pen/VPpZQL

Issue Analytics

State:
Created 7 years ago
Reactions:1
Comments:8 (2 by maintainers)

Top GitHub Comments

3reactions

levithomasoncommented, Jan 20, 2017

It is best practice to consume handled props and pass the rest along, which is what is required for the trigger to work. Here is a fork that shows the necessary changes:

http://codepen.io/levithomason/pen/QdpvRm

-const TriggerComponent = () => (
-  <span>Mouseover fails</span>
+const TriggerComponent = (props) => (
+  <span {...props}>Mouseover fails</span>
);

That said, this actually confused me at first as well. So, it is at the least unintuitive. I believe we can make this work for custom components that do not consume their props and pass the rest. I’ll leave this issue open for that work.

0reactions

layershiftercommented, Jul 27, 2020

@neutraali can you please create a new issue with a repro if you faced an issue that can’t be fixed with this comment (https://github.com/Semantic-Org/Semantic-UI-React/issues/1187#issuecomment-273988903)?