question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Create a release with assets as draft prior to releasing it

See original GitHub issue

This is related to PR #160 (I’ve not looked at the actual code) and the general approach of publishing as a draft while attaching assets to the release, instead of publishing the release prior to the release actually being finalised - as in, having the assets the release should contain.

Your arguments against including it are valid, but I am unsure that there will actually be two events triggered as a result of a draft->release promotion. From the documentation for the Github Release Event here it states that the webhook event is only triggered when a release is in fact published, not when the release is created as a draft.

I’ve not tested that that is in fact the case, however there is a field in the payload called draft: <boolean> that would indicate if the release is in fact a draft or not. My personal opinion is that respecting that field would be the proper way of handling any downstream systems responding to new releases that contains any form of payloads. Additionally, it would simplify any services that is working of off that release and expecting multiple assets to be available.

I’d be very keen to hear your thoughts on this, and I appreciate your work on this tool immensely!

Patrick

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:8 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
pmrcunhacommented, Mar 1, 2019

Hi @gr2m, that would work 😃 I can grab #160 and change it to the current behavior when there are no assets. I’ll make a new PR as soon as I’ve done it.

Thank you both for reconsidering this.

0reactions
semantic-release-botcommented, Mar 25, 2019

🎉 This issue has been resolved in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Read more comments on GitHub >

github_iconTop Results From Across the Web

Releases - GitLab Documentation
In GitLab, a release enables you to create a snapshot of your project for your users, including installation packages and release notes. You...
Read more >
Create a Release and Upload Artifacts with GitHub Actions
I have the release “content” to be my CHANGELOG.md file in my repo root, which is a markdown-formatted file. I maintain that prior...
Read more >
Prepare and roll out a release - Play Console Help
In the “Release overview” section, select View release dashboard. Select the Releases tab, then Edit. Review your draft release, make any necessary additional ......
Read more >
Set up a release | Contentful Help Center
In the Releases page, click Create new release. ... “Component: Image” entry is in draft state, you should add media that it contains...
Read more >
GitHub-Actions: Trigger on creation of Draft of GitHub-Release
When a new release should be created, a draft is created (manually), containing the proper tag , name and body . When the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found