Create a release with assets as draft prior to releasing it
See original GitHub issueThis is related to PR #160 (I’ve not looked at the actual code) and the general approach of publishing as a draft while attaching assets to the release, instead of publishing the release prior to the release actually being finalised - as in, having the assets the release should contain.
Your arguments against including it are valid, but I am unsure that there will actually be two events triggered as a result of a draft->release promotion. From the documentation for the Github Release Event here it states that the webhook event is only triggered when a release is in fact published, not when the release is created as a draft.
I’ve not tested that that is in fact the case, however there is a field in the payload called draft: <boolean>
that would indicate if the release is in fact a draft or not. My personal opinion is that respecting that field would be the proper way of handling any downstream systems responding to new releases that contains any form of payloads. Additionally, it would simplify any services that is working of off that release and expecting multiple assets to be available.
I’d be very keen to hear your thoughts on this, and I appreciate your work on this tool immensely!
Patrick
Issue Analytics
- State:
- Created 5 years ago
- Comments:8 (4 by maintainers)
Hi @gr2m, that would work 😃 I can grab #160 and change it to the current behavior when there are no assets. I’ll make a new PR as soon as I’ve done it.
Thank you both for reconsidering this.
🎉 This issue has been resolved in version 5.3.0 🎉
The release is available on:
Your semantic-release bot 📦🚀