How to correctly retry transactions

Please note this is an issue tracker, not a support forum. For general questions, please use StackOverflow or Slack.

Why I’m asking here anyway:

Now to the question: I’d like to know what to put into retry-as-promised’s match option when retrying transactions. I want to catch everything worth retrying (deadlocks, connection errors and the like), and nothing not worth retrying (syntax errors, error responses from the DB like “Data too long for column” etc.). This is what I currently have (MySQL):

match: [ // Must match error signature (ala bluebird catch) to continue
    Sequelize.ConnectionError,
    Sequelize.ConnectionRefusedError,
    Sequelize.ConnectionTimedOutError,
    Sequelize.OptimisticLockError,
    Sequelize.TimeoutError,
    'SequelizeDatabaseError: Deadlock found when trying to get lock; try restarting transaction',
    'ER_LOCK_DEADLOCK'
]

It would make me feel safer if anybody could assure me I’m not missing anything here.

[dskvr]

How to retry without conditions?

{ retry: {} }

Documentation is incomplete, no examples.

[cirosantilli]

How to retry without conditions?

{ retry: {} }

Documentation is incomplete, no examples.

Likely:

{ retry: { max: 999999999999, /.?/ } }

Max is mandatory, retry never happens without: https://github.com/mickhansen/retry-as-promised/blob/5adc050ead38f513891c7afb3c94222dee33f739/index.js#L84 as undefined < n is always false.

PostgreSQL workaround: https://stackoverflow.com/questions/68427796/sequelize-transaction-retry-doenst-work-as-expected/70204395#70204395